Add Extend and Comonad instances #15
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just throwing this out there - the
Extendinstance is a little bonkers, so we can just close this if it seems nonsensical.I feel like the
Extendinstance really should operate on each subset of the thing, so if it was a1 :| [2, 3, 4]it would callfon1 :| [2, 3, 4],2 :| [3, 4],3 :| [4],4 :| [], but unless we invented some kind ofUnconsableclass I don't think there's a way of expressing that. Given that,extendoperates on every element with an empty tail instead ¯_(ツ)_/¯.edit: I went with
Plusas the constraint since elsewhere we preferAlternativeoverMonoidclasses.